Skip to content

fix(ci): clippy all-targets lints, Windows dashboard test hang - #13

Merged
senamakel merged 2 commits into
mainfrom
ci-green-clippy
Oct 26, 2026
Merged

senamakel merged 2 commits into
mainfrom
ci-green-clippy

Conversation

@senamakel

@senamakel senamakel commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Fixes three clippy lints surfaced by --workspace --all-targets --all-features (for_unbounded_range, result_large_err, chunks_exact_to_as_chunks). The Windows rust-cross job hung for 6h on main in tests/dashboard_cli.rs: the detached dashboard server inherits the pipe handles Command::output() waits on, so the tests now capture output via files. Follow-up not done here: add timeout-minutes to the rust-cross job (needs a token with workflow scope).

Summary by CodeRabbit

  • Tests
    • Updated automated checks for browser network timeouts, WebSocket request handling, recording cursor interactions, and dashboard CLI output capture.
    • Adjusted test iteration and output handling while preserving the existing timeout assertions and application behavior.

senamakel and others added 2 commits October 26, 2026 05:11
…hang

Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Reviewed head: 92bf298f960ae7dfc6940a4f6c1c8881cfe242b8

Verdict: Ready for maintainer review · Priority: none
Coverage: Reviewed 4 of 4 files.
Pull request purpose (title): fix(ci): clippy all-…

Diagnostics and supporting details

Full summary

Pull request purpose (title): fix(ci): clippy all-targets lints, Windows dashboard test hang. This pull request fixes three clippy lints surfaced by `--workspace --all-targets --all-features` and resolves a Windows CI hang in the dashboard integration tests. No lane reported any defect, and no trusted push-delta comparison is available, so the whole-pull-request diff is the only basis for this summary.

Review snapshot

Change surface Files Review signal Count
Production 2 Active findings 0
Tests 2 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: Test coverage is assessed from changed tests and lane evidence; execution is not claimed without trusted check data.

Features

  • Internal refactor — Bounded wrapping test event counter: Replaces an unbounded range loop with a wrapping loop, satisfying the `for_unbounded_range` lint while producing the same event IDs for any test observing a handful of events. (cli/src/native/browser.rs mod tests {)
  • Modified — Lint allowance on CDP client test: Applies `#[allow(clippy::result_large_err)]` to a test, silencing the `result_large_err` lint under all-targets. (cli/src/native/cdp/client.rs mod tests {)

Tests

  • refactor — The browser test event producer loops with a wrapping counter instead of an unbounded range.: The tests lane reported no assertion weakened; the change is equivalent for tests observing only a handful of events. (cli/src/native/browser.rs mod tests {)

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 4 files; 0 findings. _The code index is behind this pull request (indexed at `47e72152bf63`), so retrieved context may be out of date._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 4 files; 0 findings. _The code index is behind this pull request (indexed at `47e72152bf63`), so retrieved context may be out of date._

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The tests lane confirmed no assertion was weakened and no branch left unpinned, treating the helper rewrite as infrastructure.
  • Lane summary: This is a correctness and clippy-compatibility cleanup: the infinite `for i in 0u64..` counter becomes a wrapping loop (numerically identical for any test that observes only a handful of events), the e2e frame splitter switches to stable `as_chunks`, and the dashboard integration helper now routes child output through temp files to avoid the documented Windows pipe-inheritance hang. The helper change is test infrastructure, not a behavioural claim needing new coverage, and the remaining `#[allow(clippy::result_large_err)]` is a lint attribute. I found no assertion that has been weakened and no branch left unpinned. _The code index is behind this pull request (indexed at `47e72152bf63`), so retrieved context may be out of date._

commits

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The commits lane reported no sensitive content in committed files.
  • Lane summary: No sensitive content in committed files. _The code index is behind this pull request (indexed at `47e72152bf63`), so retrieved context may be out of date._

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Positive: The description lane found the description accurately covers the three clippy lint reworks and the Windows dashboard hang fix, and that the scoped-out `timeout-minutes` follow-up is honestly noted.
  • Lane summary: The description accurately covers the three clippy lint reworks and the Windows dashboard test hang fix in tests/dashboard_cli.rs; the file-capture rewrite matches the stated rationale, and the follow-up note about the missing timeout-minutes is honestly scoped out. I found no defect worth reporting. _The code index is behind this pull request (indexed at `47e72152bf63`), so retrieved context may be out of date._
Evidence and run details
  • Models: deepseek-v4.1-flash, ladder/vectors-oai3
  • Spend: $0.000363
  • Tokens: 194979 input · 4411 output · 0 cached · 187 embedding
  • Updated: 2026-10-26T05:12:40Z
Head State Pass summary
92bf298f960a ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-26T05:12:40Z)

tinysweeper 0.1.2

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T05:12:54.133774Z 92bf298 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ed1e7bed-70e1-4a0e-ac02-6bd0c4a1fc92
Commits

Reviewing files that changed from the base of the PR and between 76e4892 and 92bf298.

Files selected for processing: 4
  • cli/src/native/browser.rs
  • cli/src/native/cdp/client.rs
  • cli/src/native/e2e_tests.rs
  • cli/tests/dashboard_cli.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request updates three native tests and changes the dashboard CLI integration-test helper to capture stdout and stderr in uniquely named files.

Changes: Native Test Adjustments

Layer / File(s) Summary
Native test updates
cli/src/native/browser.rs, cli/src/native/e2e_tests.rs, cli/src/native/cdp/client.rs
The request generator uses a wrapping counter, the frame loop uses as_chunks, and the WebSocket URL test allows Clippy’s result_large_err lint.

Dashboard CLI Test Output

Layer / File(s) Summary
Capture CLI output in files
cli/tests/dashboard_cli.rs
The helper redirects stdout and stderr to uniquely named files, runs the CLI with .status(), and constructs an Output from the status and file contents.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: ctate

Merge Risk: Minimal · up to 92bf2

The test changes have no established merge-blocking risk and are ready to merge after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes in the PR: Clippy lint fixes under the all-targets run, and the Windows dashboard test hang. The raw summary shows Clippy-driven edits in browser.rs, client.rs, an…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes in the PR: Clippy lint fixes under the all-targets run, and the Windows dashboard test hang. The raw summary shows Clippy-driven edits in browser.rs, client.rs, and e2e_tests.rs, and a dashboard_cli.rs change that captures output through files to avoid the pipe-inheritance hang described in the objectives. The title is specific and uses the conventional commit prefix. It does not mention that the workflow file was left unchanged, but that is a minor omission.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit counts each request in flight
And frames its video just right
The CLI leaves its output in files
While tests hop through their checks and trials
Then rabbit rests beneath the light

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

Diagnostics

Total spend: $0.0004

@senamakel
senamakel merged commit 7677f3c into main Oct 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant